What happened?

I noticed on the below PRs that Renovate is failing to run its post-upgrade commands:

• chore(deps): update module golang.org/x/crypto to v0.31.0 [security] (release-1.16) #6178
• chore(deps): update module golang.org/x/crypto to v0.31.0 [security] (release-1.17) #6179

The error message is:

Post-upgrade command 'make go.generate' has not been added to the allowed list in allowedPostUpgradeCommands

We used to allow our self-hosted Renovate to run make as post-upgrade commands, but this changed in 1cb5caa#diff-2f2dcee4f3f279ea8d2f4cd0235f2ab917d8cf1d8e11f4f195a3816afe79af26L47-R54 with the switch to Earthly.

I think the following updates could fix this:

• release-1.17 uses an Earthfile, the make commands in renovate.json5 should not include this branch
  • https://github.com/crossplane/crossplane/blob/main/.github/renovate.json5#L200
  • https://github.com/crossplane/crossplane/blob/main/.github/renovate.json5#L242
• update renovate.yml to allow make as a post-upgrade command again for 1.16
  • https://github.com/crossplane/crossplane/blob/main/.github/workflows/renovate.yml#L48
  • this workflow might only be run from main, so it may not be worth adding make again just for 1.16 that will be unsupported when 1.19 is released. We could just fix Renovate PRs to release-1.16 manually.

How can we reproduce it?

I'm not sure how to reproduce it manually, but the above PRs are good examples of the behavior.

What environment did it happen in?

Crossplane version: I see this on release-1.16 and release-1.17, which actually is odd because release-1.17 has an Earthfile and shouldn't be using make command anyways.