Check text fragments: fix matching with repeated end, fix nbsp, justify normalise #1
Merged
cristiklein merged 6 commits intoApr 19, 2026
Conversation
59d9ac0 to
4a3a80f
Compare
4a3a80f to
1cfca11
Compare
cristiklein
approved these changes
Apr 19, 2026
cristiklein
left a comment
Owner
There was a problem hiding this comment.
Nice! The regex-based matching feels a lot more readable and more robust. The new tests also gives more confidence that this actually works as expected.
| | "img" | ||
| | "meter" | ||
| | "object" | ||
| | "progresss" |
Owner
There was a problem hiding this comment.
Today I Learned.
Suggested change
| | "progresss" | |
| | "progress" // https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/progress |
| } | ||
|
|
||
| let mut text = String::new(); | ||
| let mut text: String = String::new(); |
Owner
There was a problem hiding this comment.
Out of curiosity, why is this needed?
8313b54
into
cristiklein:check-text-fragments
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.