Add Refresh buttons, fix missing auth consent, remove custom title bar causing TitleBar crash on wasdk1.7, and fix MSAL Auth exception #157
Merged
cricketthomas merged 5 commits intomasterfrom Mar 23, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the AzureKeyVaultStudio Uno app UX and reliability by adding a deterministic “Refresh” path for item details, improving interactive auth consent behavior, and preserving DataGrid sorting across refreshes.
Changes:
- Add a Refresh button/command to the item details page and update item-property selection to use the latest version by
UpdatedOn. - Update interactive sign-in to force consent and request extra scopes to ensure required permissions are granted.
- Persist DataGrid sort state and reapply sorting when vault contents refresh/reload.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/uno/global.json | Bumps Uno SDK version. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs | Adds Refresh command and selects “latest” item version for display; switches async commands to Task. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/SharedWindow.xaml.cs | Adjusts Windows-only titlebar customization preprocessor scope. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/OverrideTitlebar.xaml.cs | Exposes titlebar element for Windows and tweaks navigation indentation. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ItemDetails.xaml | Adds Refresh AppBarButton wired to the new command. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Strings/*/Resources.resw | Adds localized label for the Refresh button. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Services/AuthService.cs | Forces consent prompt and adds extra scopes to consent during interactive login. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/ViewModels/VaultViewModel.cs | Changes OpenInAzure command handler from async void to Task. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml.cs | Tracks sort column/direction and reapplies sort on refresh; updates sort indicators. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/MainPage.xaml.cs | Updates titlebar setup to use the exposed titlebar element. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Package.appxmanifest | Increments package version. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/KeyVaultValuesAmalgamation.cs | Ensures Type is populated when creating item models; adjusts collection expressions. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/App.xaml.cs | Tweaks initial window size and corrects dark theme titlebar mapping. |
| src/uno/AzureKeyVaultStudio.slnx | Updates solution project path entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml.cs
Outdated
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/KeyVaultValuesAmalgamation.cs
Outdated
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml.cs
Outdated
Show resolved
Hide resolved
Add AuthService consent to avoid admins from manually adding permissions
fb47982 to
bda841d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/MainPage.xaml.cs
Outdated
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Outdated
Show resolved
Hide resolved
...o/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Services/AuthService.cs
Outdated
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/KeyVaultValuesAmalgamation.cs
Outdated
Show resolved
Hide resolved
TitleBar crash on wasdk1.7, and fix MSAL Auth exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-03-21.111509.mp4