Skip to content

Smaller enhancements in the secret view#110

Merged
cricketthomas merged 2 commits intocricketthomas:masterfrom
Mezzenine:master
Feb 8, 2025
Merged

Smaller enhancements in the secret view#110
cricketthomas merged 2 commits intocricketthomas:masterfrom
Mezzenine:master

Conversation

@Mezzenine
Copy link
Copy Markdown
Contributor

  1. Adding multiline value for secrets
image
  1. On creating a new version, use the secret value of the previous version to edit the value
image

Mezzenine and others added 2 commits February 7, 2025 21:04
* Add scrollable multiline textblock

* Multiline secrets viewer

---------

Co-authored-by: Manz, Marc <marc.manz@vector.com>
Co-authored-by: Manz, Marc <marc.manz@vector.com>
@cricketthomas cricketthomas self-requested a review February 7, 2025 21:12
@cricketthomas cricketthomas added the v1 current version label Feb 7, 2025
@cricketthomas cricketthomas self-assigned this Feb 7, 2025
@cricketthomas cricketthomas merged commit 3576648 into cricketthomas:master Feb 8, 2025
@cricketthomas
Copy link
Copy Markdown
Owner

@Mezzenine @MarcManz-1
Thank you so much for your PR! I had no idea anyone on a Mac was using the application!

Could you tell me more about the Mac experience? I have no user logs or data for any platform other than downloads from the Microsoft Store. If you could answer the following questions or share any additional insights, I would greatly appreciate it!

  • How are you getting the latest versions?
  • Are you using an M-series chip?
  • How many users at your organization are using the application?

I’m planning to make a few other updates and will release a new version soon.

Additionally, does your organization experience any of the issues mentioned in this thread?
GitHub Issue #107

Thanks again, it feels really great to get a PR for this project i worked hard on!

@Mezzenine
Copy link
Copy Markdown
Contributor Author

@cricketthomas
Nice of you to approve my PR so quickly
Couldn't find anything better, even the Keyvault UI in the portal is totally disgusting.

  • Could you tell me more about the Mac experience?
    Yes of course.
    To be honest, installing the released version is not as easy as it could be. The unsigned executable triggers the Mac OS security check. The options you then have are not really intuitive. After going over the security check you need to know to explicitly allow the application in the security & privacy settings.

  • How are you getting the latest versions?
    From GitHub. But currently, I use my own built version.

  • Are you using an M-series chip?
    Yes, M2 PRo

  • How many users at your organization are using the application?
    I guess, just me.

Regarding the issue you mentioned, No, we haven't.

@cricketthomas
Copy link
Copy Markdown
Owner

Thanks for the reply! I aim to make the macOS experience better in the next version. Is there a reason you're using a custom built version other than the current package experience being kind of nonexistent on mac?

@Mezzenine
Copy link
Copy Markdown
Contributor Author

The reasons why I use a custom build are:

  1. I made some changes (you already reviewed) and I was to lazy to switch back
  2. I need to change the Client ID, to get access to Azure.

@cricketthomas
Copy link
Copy Markdown
Owner

Yeah, updating the client ID seems to be a big ask. I will make it so that it can be done within the app without a rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants