Skip to content

[1.35] Revert "cnimgr: continuously poll CNI STATUS to detect runtime health…#9908

Merged
haircommander merged 1 commit into
cri-o:release-1.35from
haircommander:revert-cni
Apr 29, 2026
Merged

[1.35] Revert "cnimgr: continuously poll CNI STATUS to detect runtime health…#9908
haircommander merged 1 commit into
cri-o:release-1.35from
haircommander:revert-cni

Conversation

@haircommander

@haircommander haircommander commented Apr 28, 2026

Copy link
Copy Markdown
Member

… changes"

This reverts commit c46cfe6.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Revert CRI-O CNI monitoring, as it has caused node bootstrapping regressions

@haircommander
Revert "cnimgr: continuously poll CNI STATUS to detect runtime health…
725f86e 
… changes"

This reverts commit c46cfe6.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander requested a review from mrunalp as a code owner April 28, 2026 17:01
@openshift-ci openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 28, 2026
@openshift-ci openshift-ci Bot requested review from QiWang19 and littlejawa April 28, 2026 17:01
@openshift-ci

openshift-ci Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8aed6913-cb96-46ce-a573-7145c196c6f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@codecov

codecov Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.60%. Comparing base (10e8cf6) to head (725f86e).
⚠️ Report is 2 commits behind head on release-1.35.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.35    #9908      +/-   ##
================================================
+ Coverage         64.54%   67.60%   +3.05%     
================================================
  Files               214      213       -1     
  Lines             29496    29446      -50     
================================================
+ Hits              19039    19906     +867     
+ Misses             8768     7853     -915     
+ Partials           1689     1687       -2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsorya

tsorya commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@tsorya: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo

damdo commented Apr 29, 2026

Copy link
Copy Markdown

/test images

1 similar comment
@damdo

damdo commented Apr 29, 2026

Copy link
Copy Markdown

/test images

@openshift-ci

openshift-ci Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 725f86e link true /test e2e-aws-ovn
ci/prow/e2e-gcp-ovn 725f86e link true /test e2e-gcp-ovn
ci/prow/images 725f86e link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@haircommander haircommander merged commit 35f6dd7 into cri-o:release-1.35 Apr 29, 2026
46 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@littlejawa littlejawa Awaiting requested review from littlejawa

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haircommander @tsorya @damdo