Skip to content

[release-1.34] metrics: add default_runtime#9899

Merged
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.34from
openshift-cherrypick-robot:cherry-pick-9897-to-release-1.34
Apr 22, 2026
Merged

[release-1.34] metrics: add default_runtime#9899
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.34from
openshift-cherrypick-robot:cherry-pick-9897-to-release-1.34

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 17, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #9897

/assign haircommander

add `container_runtime_crio_default_runtime` metric to display which default runtime the node is configured to use

@haircommander
metrics: add default_runtime
42236bc 
we consistently need to find which runtime a user is using, and have talked about adding this for a while. Now's the time!

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 17, 2026
Merged
@openshift-ci openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 17, 2026
@openshift-ci openshift-ci Bot requested review from QiWang19 and klihub April 17, 2026 16:17
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a309ea0-bf6d-4bc6-8f48-18b0480384ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haircommander

haircommander commented Apr 17, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2026
@codecov

codecov Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.86%. Comparing base (7d1fe5c) to head (42236bc).
⚠️ Report is 2 commits behind head on release-1.34.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.34    #9899      +/-   ##
================================================
- Coverage         64.35%   63.86%   -0.50%     
================================================
  Files               204      204              
  Lines             28492    28513      +21     
================================================
- Hits              18336    18209     -127     
- Misses             8541     8679     +138     
- Partials           1615     1625      +10
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haircommander

haircommander commented Apr 22, 2026

Copy link
Copy Markdown
Member

/lgtm
/override ci/prow/e2e-aws-ovn
/approve

@openshift-ci

openshift-ci Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-aws-ovn

Details

In response to this:

/lgtm
/override ci/prow/e2e-aws-ovn
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 78668a6 into cri-o:release-1.34 Apr 22, 2026
49 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@openshift-cherrypick-robot @haircommander