Skip to content

[release-1.35] Make artifact pinned status respect pinned_images configuration#9838

Merged
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9836-to-release-1.35
Mar 23, 2026
Merged

[release-1.35] Make artifact pinned status respect pinned_images configuration#9838
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9836-to-release-1.35

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 23, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #9836

/assign bitoku

Respect the same pinned_images configuration used by regular container images

@bitoku @claude
Make artifact pinned status respect pinned_images configuration
341f2e8 
Previously, all OCI artifacts were hardcoded as Pinned: true in
CRIImage(). This change makes artifacts respect the same pinned_images
configuration used by regular container images, by having the artifact
store check artifact names against the compiled pinned image regexps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2026
Merged
@openshift-ci openshift-ci Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 23, 2026
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ff12cce-a879-43c4-94c8-6f7f70b2d10b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 23, 2026
@openshift-ci openshift-ci Bot requested review from QiWang19 and bitoku March 23, 2026 12:41
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@openshift-ci

openshift-ci Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@codecov

codecov Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.66%. Comparing base (c22ce9f) to head (341f2e8).
⚠️ Report is 4 commits behind head on release-1.35.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.35    #9838      +/-   ##
================================================
+ Coverage         67.49%   67.66%   +0.16%     
================================================
  Files               211      211              
  Lines             29253    29283      +30     
================================================
+ Hits              19745    19813      +68     
+ Misses             7826     7786      -40     
- Partials           1682     1684       +2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot Bot merged commit 804ec10 into cri-o:release-1.35 Mar 23, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@bitoku bitoku Awaiting requested review from bitoku

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

@bitoku bitoku

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @saschagrunert @bitoku