Skip to content

[release-1.35] Fix the bug where cri-o doesn't emit any metrics when all is set.#9781

Merged
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9719-to-release-1.35
Mar 6, 2026
Merged

[release-1.35] Fix the bug where cri-o doesn't emit any metrics when all is set.#9781
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9719-to-release-1.35

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #9719

/assign bitoku

Fixed a bug where CRI-O didn't return all metrics when "all" is set.

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-ci openshift-ci Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 25, 2026
@openshift-ci openshift-ci Bot requested review from hasan4791 and klihub February 25, 2026 14:59
@openshift-ci openshift-ci Bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 25, 2026
@coderabbitai

coderabbitai Bot commented Feb 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.50%. Comparing base (c0a22cf) to head (298c604).
⚠️ Report is 8 commits behind head on release-1.35.

❗ There is a different number of reports uploaded between BASE (c0a22cf) and HEAD (298c604). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (c0a22cf) HEAD (298c604)
11 3
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.35    #9781       +/-   ##
=================================================
- Coverage         67.49%   46.50%   -21.00%     
=================================================
  Files               209      167       -42     
  Lines             29068    25579     -3489     
=================================================
- Hits              19619    11895     -7724     
- Misses             7776    12505     +4729     
+ Partials           1673     1179      -494     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku

bitoku commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@haircommander

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit f998e4a into cri-o:release-1.35 Mar 6, 2026
42 of 44 checks passed
@openshift-ci

openshift-ci Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 298c604 link unknown /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants