Skip to content

server,nri: pass container user (uid, gids) to plugins.#9708

Merged
openshift-merge-bot[bot] merged 1 commit into
cri-o:mainfrom
klihub:devel/main/nri-input/uid-gids
Jan 13, 2026
Merged

server,nri: pass container user (uid, gids) to plugins.#9708
openshift-merge-bot[bot] merged 1 commit into
cri-o:mainfrom
klihub:devel/main/nri-input/uid-gids

Conversation

@klihub

@klihub klihub commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind other

What this PR does / why we need it:

Implement missing support for passing any container user ID/group ID information to NRI plugins as input.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- nri: pass any container user ID/group ID information to NRI plugins as input

@klihub
server,nri: pass container user (uid, gids) to plugins.
23b10b8 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from mrunalp as a code owner January 12, 2026 14:55
@openshift-ci openshift-ci Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 12, 2026
@openshift-ci openshift-ci Bot requested review from QiWang19 and bitoku January 12, 2026 14:55
@openshift-ci openshift-ci Bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category labels Jan 12, 2026
@coderabbitai

coderabbitai Bot commented Jan 12, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@klihub has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5669e52 and 23b10b8.

📒 Files selected for processing (2)
  • internal/nri/container.go
  • server/nri-api.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (5669e52) to head (23b10b8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9708      +/-   ##
==========================================
+ Coverage   67.38%   67.61%   +0.23%     
==========================================
  Files         209      209              
  Lines       29047    29059      +12     
==========================================
+ Hits        19573    19649      +76     
+ Misses       7795     7730      -65     
- Partials     1679     1680       +1
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haircommander

haircommander commented Jan 12, 2026

Copy link
Copy Markdown
Member

/retest
/approve

@cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@klihub

klihub commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci

openshift-ci Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, klihub, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit eba847c into cri-o:main Jan 13, 2026
79 of 81 checks passed
@klihub klihub deleted the devel/main/nri-input/uid-gids branch January 13, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@bitoku bitoku Awaiting requested review from bitoku

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klihub @haircommander @saschagrunert