Skip to content

Conversation

@dasuken
Copy link
Contributor

@dasuken dasuken commented Feb 14, 2022

What this PR is changing or adding?

Implement getAbsoluteUrl function in the GitClone function and remove help message for create -t option because I think it is no longer needed.

Before/after or any other screenshots

スクリーンショット 2022-02-14 11 26 09

Which issues are fixed by this PR?

  1. When developers use the create -t option, they can input the url without being aware of the schema.

Or I would like to add some kind of error message when a url with a scheme is entered.

Please consider this proposal, let me know your comments. Thanks.

Pre-launch Checklist

  • I have read and fully accepted project's code of conduct.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation and/or comments to the code.
  • All existing and new tests are passing successfully.

@welcome
Copy link

welcome bot commented Feb 14, 2022

Thanks for opening this pull request! 👍 Please check out our contributing guidelines.

Copy link
Member

@koddr koddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@koddr koddr merged commit f678f4a into create-go-app:master Feb 14, 2022
@welcome
Copy link

welcome bot commented Feb 14, 2022

Congrats on merging your first pull request! 🎉 We here at Create Go App are proud of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants