Skip to content

[release-4.19] Use quadlet and start gvisor-tap-vsock before nodeip-configuration service #1056

Merged
praveenkumar merged 2 commits intocrc-org:release-4.19from
openshift-cherrypick-robot:cherry-pick-1054-to-release-4.19
May 5, 2025
Merged

[release-4.19] Use quadlet and start gvisor-tap-vsock before nodeip-configuration service #1056
praveenkumar merged 2 commits intocrc-org:release-4.19from
openshift-cherrypick-robot:cherry-pick-1054-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 2, 2025 •
edited by sourcery-ai bot
Loading

This is an automated cherry-pick of #1054

/assign praveenkumar

Summary by Sourcery

Modify gvisor-tap-vsock service configuration to use quadlet and ensure it starts before nodeip-configuration service

Enhancements:

  • Migrate gvisor-tap-vsock service to use quadlet-style container configuration

Chores:

  • Update service startup order to run before nodeip-configuration service

@praveenkumar
Use quadlet instead of podman generate systemd command
70c1fab 
podman generate systemd command is deprecated and recommend to use
quadlet.
```
DEPRECATED command:
It is recommended to use Quadlets for running containers and pods under systemd.
```
@praveenkumar
Start gvisor-tap-vsock before nodeip-configuration service
bf82eeb 
Recently with latest version of 4.18.10, noticed nodeip-configuration
unit starts before gvisor-tap-vsock and blocks it. This cause problem
to get IP address of VM.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented May 2, 2025 •
edited
Loading

Reviewer's Guide

This pull request updates the createdisk.sh script to manage the gvisor-tap-vsock service using quadlet instead of direct podman create and podman generate systemd commands. It also ensures this service starts before nodeip-configuration.service.

File-Level Changes

Change Details Files
Replace manual podman commands with quadlet for gvisor-tap-vsock service.
  • Removed podman create and podman generate systemd commands.
  • Added creation of /etc/containers/systemd/gvisor-tap-vsock.container via heredoc.
  • Defined container settings (image, network, volume, args) within the quadlet file.
 createdisk.sh
Ensure gvisor-tap-vsock starts before nodeip-configuration.
  • Added Before=nodeip-configuration.service to the [Unit] section of the quadlet file.
 createdisk.sh
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci openshift-ci bot requested review from cfergeau and gbraad May 2, 2025 07:29
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented May 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented May 2, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@praveenkumar
Copy link
Copy Markdown
Member

praveenkumar commented May 5, 2025

/ok-to-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented May 5, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift bf82eeb link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit dd46b03 into crc-org:release-4.19 May 5, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfergeau cfergeau Awaiting requested review from cfergeau

@gbraad gbraad Awaiting requested review from gbraad

Assignees

@praveenkumar praveenkumar

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@openshift-cherrypick-robot @praveenkumar