Skip to content

Add input options related to copy()#161

Merged
crazy-max merged 5 commits intocrazy-max:devfrom
yrd:copy-option-inputs
Jan 13, 2022
Merged

Add input options related to copy()#161
crazy-max merged 5 commits intocrazy-max:devfrom
yrd:copy-option-inputs

Conversation

@yrd
Copy link
Contributor

@yrd yrd commented Jan 13, 2022

This PR adds two new input options:

  • absolute_build_dir treats the build_dir option as absolute, instead of a path relative to the current working directory (see Allow absolute paths for the build_dir option #159)
  • follow_symlinks will dereference symbolic links, allowing entire directory trees to be copied

yrd added 3 commits January 13, 2022 10:06
This commit adds absolute_build_dir as an additional input. If the
option is set, the provided build_dir argument won't be treated as a
relative path to the current working directory anymore. This is helpful
in environments like Nix, where the build is output to a static folder
(for example /nix/store).

Closes crazy-max#159.
This option allows symbolic links in the source directory to be
followed, recursively copying the entire directory structure.
@yrd yrd requested a review from crazy-max as a code owner January 13, 2022 09:15
@crazy-max crazy-max linked an issue Jan 13, 2022 that may be closed by this pull request
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit otherwise lgtm

This concerns absolute_build_dir and follow_symlinks.

Co-authored-by: CrazyMax <github@crazymax.dev>
@yrd yrd requested a review from crazy-max January 13, 2022 09:47
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 0c20c87 into crazy-max:dev Jan 13, 2022
@yrd
Copy link
Contributor Author

yrd commented Jan 13, 2022

Thank you!

@yrd yrd deleted the copy-option-inputs branch January 13, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow absolute paths for the build_dir option

2 participants