Skip to content

CI: httpbin.org intermittently rejects requests, so use iana.org#91

Merged
amotl merged 1 commit intomainfrom
fix-flaky-ci
Nov 3, 2025
Merged

CI: httpbin.org intermittently rejects requests, so use iana.org#91
amotl merged 1 commit intomainfrom
fix-flaky-ci

Conversation

@amotl
Copy link
Member

@amotl amotl commented Nov 3, 2025

About

Improve flaky CI/GHA.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The test test_fragment_remote_failure was updated to use a different URL endpoint for failure testing. The failing URL changed from httpbin.org/404 to iana.org/404, with corresponding updates to the expected error message assertions.

Changes

Cohort / File(s) Summary
Test URL Update
tests/test_prompt.py
Updated test_fragment_remote_failure to reference https://www.iana.org/404 instead of https://httpbin.org/404; adjusted expected error message assertions to match the new URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple, single-file change with URL and corresponding string updates
  • No logic changes or behavioral modifications
  • Straightforward assertion updates to match new test endpoint

Poem

🐰 A URL hops from site to site,
From httpbin to iana bright,
The tests still pass, the errors still fail,
Just different domains tell the tale! 🌐

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-flaky-ci

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e131a88 and 7693892.

📒 Files selected for processing (1)
  • tests/test_prompt.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl marked this pull request as ready for review November 3, 2025 15:24
@amotl amotl merged commit 9610d7b into main Nov 3, 2025
11 checks passed
@amotl amotl deleted the fix-flaky-ci branch November 3, 2025 15:24
@coderabbitai coderabbitai bot mentioned this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant