Tame logging of HTTPX to not reveal credentials#86
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA changelog entry documents HTTPX logging security improvements. The CLI entrypoint now configures the HTTPX logger to WARNING level during initialization to prevent credential exposure in logs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
55be3ab to
421fc9b
Compare
surister
approved these changes
Nov 3, 2025
Contributor
surister
left a comment
There was a problem hiding this comment.
LGTM, shame that it wasn't fixed at the core
421fc9b to
177cd86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Recommendation
The recommendation is to alter the log level of HTTPX? Well, let's do it then, until swapping it for another library?
References
Summary by CodeRabbit