Conversation
WalkthroughThe project configuration was updated to add support for Python 3.14. The GitHub Actions workflow matrix and Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/tests.yml(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: oci
- GitHub Check: oci
🔇 Additional comments (1)
.github/workflows/tests.yml (1)
30-33: I need to verify several aspects of the review comment. Let me check the actual pyproject.toml classifiers and Python 3.14 status.Now let me check the actual project configuration files:
Let me now verify the actual project configuration files:
Let me run a script to verify the actual configuration in the repository:
Address the test matrix coverage gap or document the strategy.
Python 3.14.0 was released on October 7, 2025, so testing this version is timely and appropriate. However, the workflow now tests only Python 3.10 and 3.14, which creates a gap in intermediate versions.
Without access to your
pyproject.tomlclassifiers to confirm which versions are declared as supported, I cannot definitively verify if this test matrix choice aligns with your stated support policy. However, the concern is valid: if you declare support for Python 3.11, 3.12, and 3.13 in classifiers, they should be tested, or the classifiers should be updated to reflect the actual tested versions.Consider one of these approaches:
- Expand the test matrix to include intermediate versions if they are declared as supported
- Update classifiers to reflect only tested versions (3.10, 3.14)
- Document the test strategy (e.g., "testing endpoints only for cost/speed optimization") in a README or workflow comment
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
There was a problem hiding this comment.
🧩 Analysis chain
Classifier addition is properly placed and correctly formatted.
The "Programming Language :: Python :: 3.14" classifier is correctly added and maintains version ordering. Ensure all pinned dependencies (especially fastmcp>=2.13,<2.14, pueblo==0.0.11) are compatible with Python 3.14 before release.
Search the web for the latest compatibility status of the pinned dependencies with Python 3.14:
🌐 Web query:
Are fastmcp 2.13 and pueblo 0.0.11 compatible with Python 3.14?
💡 Result:
Short answer: Not officially — neither package declares Python 3.14 support on PyPI, though both publish py3 wheels that will often install on 3.14.
- fastmcp 2.13: Requires Python >=3.10 and classifiers list up to Python 3.13 (no 3.14 classifier). [1]
- pueblo 0.0.11: Requires Python >=3.7 and classifiers list up to Python 3.13 (no 3.14 classifier). [2]
Recommendation: You can try installing them on Python 3.14 (the py3-none-any wheels usually install), but run your test suite — if you hit issues, open an issue with the project with Python 3.14 reproduction steps.
Sources: PyPI fastmcp (classifiers & requires). [1] PyPI pueblo 0.0.11 (classifiers & requires). [2]
Do not add the Python 3.14 classifier yet.
fastmcp 2.13 and pueblo 0.0.11 do not officially declare Python 3.14 support in their PyPI classifiers (both stop at 3.13). While their wheels may install on Python 3.14, adding a 3.14 classifier to this package without official dependency support risks downstream issues. Before adding the classifier, either:
- Wait for fastmcp and pueblo to officially release 3.14 support, or
- Run the full test suite on Python 3.14, confirm all tests pass, then open issues upstream with the dependencies requesting 3.14 support
🤖 Prompt for AI Agents
In pyproject.toml around lines 49-50 the Python 3.14 Trove classifier was added
prematurely; remove the "Programming Language :: Python :: 3.14" classifier (or
revert that change) and keep only up to 3.13 until dependencies fastmcp and
pueblo officially declare 3.14 support or you have run the full test suite on
Python 3.14 and confirmed everything passes and/or filed upstream issues
requesting 3.14 compatibility; after that, add the 3.14 classifier only when
dependency support is confirmed.
See title.
Summary by CodeRabbit