Skip to content

Remove trailing '/' if it exists#32

Merged
surister merged 1 commit intocrate:mainfrom
surister:fix/url-fix
May 21, 2025
Merged

Remove trailing '/' if it exists#32
surister merged 1 commit intocrate:mainfrom
surister:fix/url-fix

Conversation

@surister
Copy link
Contributor

@surister surister commented May 21, 2025 •
edited by amotl
Loading

Summary of the changes / Why this is an improvement

In our docs we recommend setting "CRATEDB_CLUSTER_URL": "http://localhost:4200/" but in https://github.com/surister/cratedb-mcp/blob/5c8f404211e33e6a5e9b697fbd728d9f5139a70a/cratedb_mcp/__main__.py#L18 we add an /, this small patch fixes it.

Checklist

@surister surister requested a review from amotl May 21, 2025 15:57
@coderabbitai
Copy link

coderabbitai bot commented May 21, 2025 •
edited
Loading

"""

Walkthrough

The query_cratedb function in cratedb_mcp/__main__.py was updated to include a descriptive docstring and logic to remove a trailing slash from the HTTP_URL variable before forming the SQL endpoint URL. No changes were made to the function's signature or core functionality.

Changes

File(s) Change Summary
cratedb_mcp/main.py Added a docstring to query_cratedb and implemented logic to strip trailing slash from HTTP_URL before constructing the request URL. No changes to the function's signature.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Ensure cluster can be queried even if CRATEDB_CLUSTER_URL ends with a slash (#30) ✅

Poem

A slash at the end, oh what a plight,
Now trimmed away, the URL’s right!
CrateDB queries, swift as a hare,
No more errors, just data to share.
With a hop and a skip, the bug is gone—
The code hops forward, moving on!
🐇✨
"""

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b152354 and 70ccf74.

📒 Files selected for processing (1)
  • cratedb_mcp/__main__.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • cratedb_mcp/main.py
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c8f404 and 346cd80.

📒 Files selected for processing (1)
  • cratedb_mcp/__main__.py (1 hunks)
🧰 Additional context used
🪛 Ruff (0.11.9)
cratedb_mcp/__main__.py

17-17: Local variable HTTP_URL referenced before assignment

(F823)

🪛 GitHub Actions: Tests
cratedb_mcp/__main__.py

[error] 1-1: Ruff formatting check failed. File would be reformatted. Run 'ruff format --fix' to fix code style issues.

🔇 Additional comments (2)
cratedb_mcp/__main__.py (2)

16-16: Good addition of a docstring!

Adding documentation to the function improves code readability and maintainability.

1-71: Fix formatting issues in the file.

The pipeline failure indicates that there are formatting issues in this file. Run ruff format --fix to address these issues as mentioned in the error message.

🧰 Tools
🪛 Ruff (0.11.9)

17-17: Local variable HTTP_URL referenced before assignment

(F823)

🪛 GitHub Actions: Tests

[error] 1-1: Ruff formatting check failed. File would be reformatted. Run 'ruff format --fix' to fix code style issues.

amotl
amotl approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Classic off-by-one trailing slash error. Thanks for spotting and fixing!

@surister surister merged commit 9c53599 into crate:main May 21, 2025
3 of 6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@amotl amotl amotl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cannot query cluster

2 participants

@surister @amotl