Skip to content

Dependencies: Update to FastMCP 2.0#24

Merged
amotl merged 1 commit intomainfrom
fastmcp
May 19, 2025
Merged

Dependencies: Update to FastMCP 2.0#24
amotl merged 1 commit intomainfrom
fastmcp

Conversation

@amotl
Copy link
Member

@amotl amotl commented May 17, 2025

About

FastMCP 2.0 significantly expands on 1.0 by introducing powerful client capabilities, server proxying & composition, OpenAPI/FastAPI integration, and more advanced features.

-- FastMCP 2.0 and the Official MCP SDK

@amotl amotl requested review from kneth and surister May 17, 2025 15:57
@coderabbitai
Copy link

coderabbitai bot commented May 17, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the project to use the new FastMCP package (version 2.0) instead of the previous MCP package. Import statements are adjusted accordingly, dependency specifications are updated, and the changelog is revised to reflect the upgrade and new features in FastMCP 2.0.

Changes

File(s) Change Summary
CHANGES.md Updated changelog with FastMCP 2.0 upgrade details and a link to the SDK documentation.
cratedb_mcp/main.py, tests/test_cli.py Changed FastMCP import source from mcp.server.fastmcp to fastmcp; added type annotation in main; updated test mocks from anyio.run to mcp.run_async.
pyproject.toml Replaced "mcp[cli]>=1.5.0" with "fastmcp<3" in dependencies.

Suggested reviewers

  • bmunkholm
  • surister

Poem

A hop and a skip, our code takes a leap,
FastMCP’s here—no time for sleep!
New imports align, dependencies shine,
The changelog now tells of features so fine.
With every update, our project’s in sync—
🐇 Cheers to new code and a fresh rabbit wink!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c38ce5 and 350a074.

📒 Files selected for processing (4)
  • CHANGES.md (1 hunks)
  • cratedb_mcp/__main__.py (2 hunks)
  • pyproject.toml (1 hunks)
  • tests/test_cli.py (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch fastmcp
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 17, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
cratedb_mcp/__main__.py (1)

12-12: Consider removing the redundant type annotation.

The mcp: FastMCP = FastMCP("cratedb-mcp") annotation is semantically correct but may be inferred by type checkers automatically. You could drop the explicit : FastMCP to reduce verbosity if desired.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1e4718 and 6c38ce5.

📒 Files selected for processing (4)
  • CHANGES.md (1 hunks)
  • cratedb_mcp/__main__.py (2 hunks)
  • pyproject.toml (1 hunks)
  • tests/test_cli.py (1 hunks)
🔇 Additional comments (3)
tests/test_cli.py (1)

5-5: Import path updated to the top-level fastmcp package.

Switching from mcp.server to fastmcp aligns with the new dependency. Please verify there are no leftover references to mcp.server elsewhere and that the FastMCP API (e.g. .run(), the @tool decorator) remains unchanged in v2.0.

CHANGES.md (1)

4-7: Changelog entry clearly documents the FastMCP 2.0 upgrade.

The “Unreleased” section describes the move to FastMCP 2.0 and includes a reference link. The formatting is appropriate—just ensure the URL is reachable and correctly formatted in rendered Markdown.

Also applies to: 9-9

cratedb_mcp/__main__.py (1)

2-2: Update import to use the new FastMCP package.

You’ve replaced from mcp.server.fastmcp with from fastmcp. Confirm that v2.0’s entry points (like FastMCP.tool) have the same signatures so that all decorated tools continue to register correctly.

@amotl amotl marked this pull request as ready for review May 17, 2025 16:03
@amotl amotl merged commit 0829bec into main May 19, 2025
5 of 6 checks passed
@amotl amotl deleted the fastmcp branch May 19, 2025 23:21
This was referenced Jul 18, 2025
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@kneth kneth kneth approved these changes

@surister surister Awaiting requested review from surister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amotl @kneth