NG: Theme modernization, last mile#506
Conversation
|
Thank you very much for adding so much progress to this. Hereby, I am starting a small collection of backlog items. Some of them might be unrelated to the modernization, some indeed are.
|
|
fixed bigger quote text via 786fd2a (apparently that also happened on the current docs, but I couldn't find an example) |
|
@amotl the ToC error is "fixed" with 08586b7 Pages with code snippets or other content that's wider than the screen don't screw up the layout anymore, had to give up fluid containers for that, but we'll survive without ;) I did however find a strange 404 which tries to load a css asset from Other than that: Algolia instantsearch is included now, but needs some more love to get the URL right (i.e. it points to Honorable mentions: left sidebar has a grey background now and should always be boxed and not overflow at the bottom. With that fixed, I gave the menu items 2px more padding for easier navigation and better UX. Search button is square again to fit in with the other elements. Also added and finetuned a few breakpoints for when the sidebars and header disappear. |
|
Hi. I love the appearance as seen on the preview now. Thanks a stack for working on this and bringing it to this level. 🌻 While the overall appearance is not revolutionary different than before, everyone who knows reasonably well about the ingredients of the new theme will very much appreciate it, and we certainly do! One final things comes to mind: What about slotting in the SEARCH button into a different location instead? When possible, let's also hear about voices from others on this and other details. Thanks! /cc @seut, @matriv, @matkuliak, @proddata, @ckurze, @geragray NB: 1_572 lines of codes removed. Getting rid of old-fashioned CSS which added drag to maintenance? Great job! |
|
@proddata I had the search in the left sidebar once already, but this means on mobile it will only be visible when the sidebar is open (or we duplicate the field and show it somewhere else when it disappears). I was also playing around with the position of the version chooser and it didn't look great when it wasn't aligned with the top nav. However, if we lose it, that shouldn't be a problem anymore. Should we keep Login/Get CrateDB or drop them as well? Btw, can you do a hard refresh? No idea where some of those background colors are coming from in your screenshot, I don't see that bar on the right ;) |
Considering that searching is going away from the page anyway I would consider it fine.
We might want to keep "Login" and "Get CrateDB" and add a button back to the homepage?
Are you using an external mouse or a device with just a touchpad?
|
This comment was marked as resolved.
This comment was marked as resolved.
Thank you very much for your recent changes. Perfect! 🌻 |
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks good now 👍 |
e06e187 to
7576f47
Compare
…ts with the same name
7576f47 to
4253506
Compare



About
Improvements for the big modernization patch, submitted by @msbt. Thanks!
sphinx-basic-ng#390Preview
https://crate-docs-theme--506.org.readthedocs.build/en/506/