Skip to content

Introduce ReferenceAssert to make Reference assertions composable#14632

Merged
mergify[bot] merged 1 commit intomasterfrom
b/reference-asserts
Aug 30, 2023
Merged

Introduce ReferenceAssert to make Reference assertions composable#14632
mergify[bot] merged 1 commit intomasterfrom
b/reference-asserts

Conversation

@BaurzhanSakhariev
Copy link
Contributor

@BaurzhanSakhariev BaurzhanSakhariev commented Aug 30, 2023

Addressing #14617 (comment)

@BaurzhanSakhariev BaurzhanSakhariev mentioned this pull request Aug 30, 2023
Closed
2 tasks
jeeminso
jeeminso approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jeeminso jeeminso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BaurzhanSakhariev BaurzhanSakhariev added ready-to-merge Let Mergify merge the PR once approved and checks pass and removed ready-to-merge Let Mergify merge the PR once approved and checks pass labels Aug 30, 2023
@BaurzhanSakhariev
Copy link
Contributor Author

BaurzhanSakhariev commented Aug 30, 2023

retest this please

unrelated MetadataTrackerTest failure

@BaurzhanSakhariev BaurzhanSakhariev added the ready-to-merge Let Mergify merge the PR once approved and checks pass label Aug 30, 2023
@mergify mergify bot merged commit 8acb044 into master Aug 30, 2023
@mergify mergify bot deleted the b/reference-asserts branch August 30, 2023 17:13
This was referenced Aug 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeeminso jeeminso jeeminso approved these changes

Assignees

No one assigned

Labels

ready-to-merge Let Mergify merge the PR once approved and checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BaurzhanSakhariev @jeeminso