Skip to content

Implement support for non-recursive, DQL WITH sql statements#12540

Merged
mergify[bot] merged 1 commit intomasterfrom
s/with-statement
May 20, 2022
Merged

Implement support for non-recursive, DQL WITH sql statements#12540
mergify[bot] merged 1 commit intomasterfrom
s/with-statement

Conversation

@seut
Copy link
Member

@seut seut commented May 19, 2022

Summary of the changes / Why this improves CrateDB

Non-recursive WITH statements, which only contain DQL statements, can be simply rewritten to (nested) sub-select queries.
Recursive or materialized WITH and the usage of DML statements is not supported.

Relates #11757.

Checklist

  • Added an entry in CHANGES.txt for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in CHANGES.txt
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

@seut seut requested a review from BaurzhanSakhariev May 19, 2022 15:03
BaurzhanSakhariev
BaurzhanSakhariev approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@BaurzhanSakhariev BaurzhanSakhariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great, only minor comment on doc

@seut seut requested a review from BaurzhanSakhariev May 20, 2022 06:55
@seut
Implement support for non-recursive, DQL WITH sql statements
c38b92d 
Non-recursive WITH statements, which only contain DQL statements,
can be simply rewritten to (nested) sub-select queries.

Recursive or materialized WITH and the usage of DML statements is
not supported.
@seut seut force-pushed the s/with-statement branch from ce6b22b to c38b92d Compare May 20, 2022 07:21
@seut seut added the ready-to-merge Let Mergify merge the PR once approved and checks pass label May 20, 2022
@mergify mergify bot merged commit 354ac6b into master May 20, 2022
@mergify mergify bot deleted the s/with-statement branch May 20, 2022 09:06
@seut seut mentioned this pull request May 20, 2022
Closed
@mfussenegger mfussenegger mentioned this pull request May 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BaurzhanSakhariev BaurzhanSakhariev BaurzhanSakhariev approved these changes

Assignees

No one assigned

Labels

ready-to-merge Let Mergify merge the PR once approved and checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seut @BaurzhanSakhariev