.github/workflows/tests.yml (1)

39-40: 💡 Verification agent

🧩 Analysis chain

Verify if 'sponge' is still needed in the workflow.

Since you've moved from the old build process to a new CLI command, is the sponge utility still required? If it was only used in the removed poe build task, consider removing this installation step.

---

🏁 Script executed:

#!/bin/bash
# Check if sponge is still used in the codebase

# Search for sponge usage in Python files
echo "Looking for sponge usage in Python files:"
rg "sponge" --type py

# Search for sponge usage in shell scripts or other files
echo "Looking for sponge usage in other files:"
rg "sponge" --type-not py

Length of output: 231

---

Remove unused sponge installation

No references to sponge were found anywhere in the codebase, so you can safely delete the installation step in your CI workflow.

• File: .github/workflows/tests.yml
Lines 39–40 – remove the following:

-      - name: Install `sponge`
-        run: sudo apt-get --yes install moreutils

CHANGES.md (1)

9-10: Changelog entry needs a grammatical correction.

There's a minor grammar issue in the changelog entry.

- CLI: Zapped working tree building by establishing new `cratedb-about build`
+ CLI: Zapped working tree building by establishing a new `cratedb-about build`

🧰 Tools

🪛 LanguageTool

[uncategorized] ~9-~9: You might be missing the article “a” here.
Context: ...d working tree building by establishing new cratedb-about build subcommand ## ...

(AI_EN_LECTOR_MISSING_DETERMINER_A)

tests/test_cli.py (2)

62-76: New test added for the 'build' command.

The test covers basic functionality by verifying exit code and expected log messages. Consider enhancing it to verify the actual output files are created correctly.

def test_cli_build(caplog, tmp_path):
    runner = CliRunner()

    result = runner.invoke(
        cli,
        args=["build"],
        env={"OUTDIR": str(tmp_path)},
        catch_exceptions=False,
    )
    assert result.exit_code == 0, result.output

    assert "Building llms-txt" in caplog.text
    assert "Dumping outline source file" in caplog.text
    assert "Generating llms-txt files" in caplog.text
    assert "Ready." in caplog.text
+    
+    # Verify that the expected output files are created
+    assert (tmp_path / "llms.txt").exists()
+    assert (tmp_path / "llms-full.txt").exists()

---

62-76: Consider adding tests for error scenarios.

The current test only covers the happy path. Consider adding tests for error cases, such as when OUTDIR is not set or points to a non-existent directory.

def test_cli_build_without_outdir():
    runner = CliRunner()

    # Test without OUTDIR environment variable
    result = runner.invoke(
        cli,
        args=["build"],
        env={},  # No OUTDIR set
        catch_exceptions=False,
    )
    # Verify appropriate error handling
    assert result.exit_code != 0
    assert "Error" in result.output or "OUTDIR" in result.output

src/cratedb_about/build/llmstxt.py (1)

20-43: Add error handling for build operations.

The current implementation doesn't handle potential errors during file operations or command execution. Adding try-except blocks would make the build process more robust.

def run(self):
    logger.info(f"Building llms-txt. Output directory: {self.outdir}")
-   self.outdir.mkdir(parents=True, exist_ok=True)
+   try:
+       self.outdir.mkdir(parents=True, exist_ok=True)
+   except Exception as e:
+       logger.error(f"Failed to create output directory: {e}")
+       raise

    logger.info("Copying source and documentation files")
-   shutil.copy(
-       str(resources.files("cratedb_about.build") / "llmstxt-about.md"),
-       self.outdir / "readme.md",
-   )
-   shutil.copy(
-       str(resources.files("cratedb_about.outline") / "cratedb-outline.yaml"),
-       self.outdir / "outline.yaml",
-   )
+   try:
+       shutil.copy(
+           str(resources.files("cratedb_about.build") / "llmstxt-about.md"),
+           self.outdir / "readme.md",
+       )
+       shutil.copy(
+           str(resources.files("cratedb_about.outline") / "cratedb-outline.yaml"),
+           self.outdir / "outline.yaml",
+       )
+   except Exception as e:
+       logger.error(f"Failed to copy resource files: {e}")
+       raise

    # ... similar error handling for command execution

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro