Skip to content

Chore: Use public_html as build folder. build is used for Python.#14

Merged
amotl merged 1 commit intomainfrom
alternate-build-dir
May 9, 2025
Merged

Chore: Use public_html as build folder. build is used for Python.#14
amotl merged 1 commit intomainfrom
alternate-build-dir

Conversation

@amotl
Copy link
Member

@amotl amotl commented May 9, 2025

What the title says.

@coderabbitai
Copy link

coderabbitai bot commented May 9, 2025 •
edited
Loading

Walkthrough

The changes update the build output directory from build/llm to public_html/llm in the build configuration and adjust the .gitignore file to ignore the public_html directory instead of specific files in build/llm. No modifications were made to source files or exported entities.

Changes

File(s) Change Summary
.gitignore Removed ignore rules for build/llm/*.txt and build/llm/cratedb-overview.md; added public_html/ to ignore list.
pyproject.toml Updated build task commands to use public_html/llm as the target directory instead of build/llm.

Poem

In the warren, files shift and twirl,
From build to public_html they whirl.
Ignore the old, embrace the new,
Directories hop with a different view.
Bunny paws type and softly cheer—
The project’s path is crystal clear! 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amotl amotl merged commit 75302da into main May 9, 2025
2 of 3 checks passed
@amotl amotl deleted the alternate-build-dir branch May 9, 2025 14:07
coderabbitai[bot]
coderabbitai bot reviewed May 9, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.gitignore (1)

7-7: Use an anchored ignore pattern for public_html.
To explicitly ignore only the root public_html/ directory (and avoid matching files or folders named public_html elsewhere), update the entry to include leading and trailing slashes:

-public_html
+/public_html/
pyproject.toml (1)

168-168: Clean up stale artifacts before creating new build output.
Introduce a removal step to avoid orphaned files from previous runs:

-{ shell = "mkdir -p public_html/llm" },
+{ shell = "rm -rf public_html/llm && mkdir -p public_html/llm" },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea078b3 and 5fa867d.

📒 Files selected for processing (2)
  • .gitignore (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (2)
pyproject.toml (2)

168-172: Build output path updated correctly.
The build task now creates and populates public_html/llm, aligning with the .gitignore change. No issues detected here.

168-172:

Details

✅ Verification successful

Verify no residual build/llm references remain.
Ensure that CI workflows, documentation or deployment scripts no longer point to the old path by running:

[Any matches should be updated or removed.]

🏁 Script executed:

rg -n 'build/llm'

Length of output: 17

No residual build/llm references found.
Running rg -n 'build/llm' produced no matches, confirming that CI workflows, documentation, and deployment scripts no longer reference the old path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@amotl