Chore: Clean up build folder. Sources should be in src.#13
Conversation
|
Warning Rate limit exceeded@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🛑 Comments failed to post (1)
pyproject.toml (1)
167-172: 🛠️ Refactor suggestion
Ensure the
build/llmdirectory exists and improve portability of the copy step
The newcpinvocation will error ifbuild/llmis missing and may not work on Windows hosts. Consider pre-creating the folder and/or using a Python copy for cross-platform reliability:build = [ { shell = "cp src/index/cratedb-overview.md build/llm/" }, - { shell = "cp src/content/about/llms-txt.md build/llm/readme.md" }, + { shell = "mkdir -p build/llm && cp src/content/about/llms-txt.md build/llm/readme.md" }, { shell = "llms_txt2ctx --optional=false src/index/cratedb-overview.md > build/llm/llms.txt" }, { shell = "llms_txt2ctx --optional=true src/index/cratedb-overview.md > build/llm/llms-full.txt" }, ]Or, for full cross-OS support:
- { shell = "cp src/content/about/llms-txt.md build/llm/readme.md" }, + { shell = "python - <<'PYCODE'\nimport shutil, pathlib\npathlib.Path('build/llm').mkdir(parents=True, exist_ok=True)\nshutil.copy('src/content/about/llms-txt.md', 'build/llm/readme.md')\nPYCODE" },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.build = [ { shell = "cp src/index/cratedb-overview.md build/llm/" }, { shell = "mkdir -p build/llm && cp src/content/about/llms-txt.md build/llm/readme.md" }, { shell = "llms_txt2ctx --optional=false src/index/cratedb-overview.md > build/llm/llms.txt" }, { shell = "llms_txt2ctx --optional=true src/index/cratedb-overview.md > build/llm/llms-full.txt" }, ]🤖 Prompt for AI Agents (early access)
In pyproject.toml around lines 167 to 172, the build steps use shell commands to copy files into the build/llm directory, but this will fail if the directory does not exist and may not work on Windows. To fix this, modify the build process to first ensure the build/llm directory is created before copying files, and replace the shell cp commands with Python-based copy operations for cross-platform compatibility.
About
Just a minor cleanup.