ensure there's no field layouts with the same uid too #18193
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
utils/fix-field-layout-uidscommand fixes duplicate or missing UUIDs that are found inside of given field layout.This PR builds on top of that to ensure that all field layouts themselves also have unique UUIDs.
Background:
As issue was reported via support, where an upgrade from v4 to v5 caused some content to go missing.
Digging into it, I found that when entrifying matrix blocks, three blocks were converted to an entry type with wrong fields - fields that belonged to a different block in a different matrix field. When two field layouts have the same UID, a wrong one can be grabbed here: https://github.com/craftcms/cms/blob/5.8.21/src/migrations/m230617_070415_entrify_matrix_blocks.php#L107, leading to the described problem.
Related issues
n/a; reported by @olivierbon