ensure return element #18185
Merged
ensure return element #18185
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Went with a check to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a new nested entry is created for the matrix field in inline-editable blocks mode, it’s first created as a draft and so has a
draftId. That new entry, withdraftId, is passed back to the view and rendered. Then the owner element is auto-saved, triggeringNestedElementManager->saveNestedElements(), which triggers theDrafts->removeDraftData(), which causes thedraftIdfor that matrix “block” to be nullified.If you then use the “copy” element action without reloading the page, the element data will contain the
draftIdthat’s no longer applicable. When pasting, the canonical element is still found, but instead of being returned, we redirect to its control panel URL, causing the described issue.Fix: when triggering the “copy” action, the element info can contain an extra
ensureReturnElementparam, which, when set to true, will enforce the element being returned instead of the redirect.Related issues
#18175