when verifying passkey, use getHostName to build the server request
#18048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating and verifying the passkey, we use
Craft::$app->getRequest()->getHostName()to get the right domain. However, when logging in a user via passkey, we rely on globals. That works in the majority of cases, but causes issues in the Cloud.Fix: ensure that we use the same method to get the domain when building the server request used to verify a passkey.
@olivierbon, @brianjhanson - thanks for doing all the investigative work and coming up with the initial solution. I just tweaked it a bit.
Related issues
n/a; reported via support