Fix compilation with latest ROS 2 source#605
Merged
SteveMacenski merged 2 commits intocra-ros-pkg:foxy-develfrom Oct 26, 2020
jacobperron:ros2_updates
Merged
Fix compilation with latest ROS 2 source#605SteveMacenski merged 2 commits intocra-ros-pkg:foxy-develfrom jacobperron:ros2_updates
SteveMacenski merged 2 commits intocra-ros-pkg:foxy-develfrom
jacobperron:ros2_updates
Conversation
After some cleanup in ros2/geometry2#325, the header is no longer being transitively included. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The namespace rclcpp::executors:: was deprecated in Foxy and removed in ros2/rclcpp#1327. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Contributor
Author
|
I'm not sure if the test failure is related. Seems like it could be a flake? |
Collaborator
|
toggling CI |
Contributor
Author
|
CI looks good now 🙂 |
SteveMacenski
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two changes to fix building with the latest version of ROS 2 from source:
After some cleanup in Style fixup in tf2_ros. ros2/geometry2#325, the header is no longer being transitively included.
The namespace rclcpp::executors:: was deprecated in Foxy and removed in Remove deprecated executor::FutureReturnCode APIs ros2/rclcpp#1327.
I believe both changes are compatible with ROS Foxy.