Skip to content

Implement date/time and reflection classes for engine-js#1698

Merged
JPercival merged 4 commits intomainfrom
time-reflection-engine-js
Mar 12, 2026
Merged

Implement date/time and reflection classes for engine-js#1698
JPercival merged 4 commits intomainfrom
time-reflection-engine-js

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Mar 9, 2026 •
edited
Loading

  • Implement reflection methods for JavaClass for JS environments for engine core types.
  • Implement date/time classes for JS environments using kotlinx-datetime. Use timezone logic from js-joda.
  • Migrate DateTest, DateTimeTest, IntervalHelperTest, TemporalHelperTest from jvmTest to commonTest.
  • Fix BigDecimalJs(String) constructor to make it more consistent with Java's BigDecimal(String).
  • Small improvements to the playground UI.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Related Issues

The following open issues may be related to this PR:

Issue Title Score Matched Terms
#734 Width allows Interval as a parameter 7.5 "date time", time, implement, date, engine (path), org (path), cql (path)
#886 ToString() does not return timezone extension 6 "date time", time, date, org (path), cql (path)
#895 Integrate code generation into the cql-engine build 5.5 classes, java (path), src (path), opencds (path), engine (path), main (path), org (path), cql (path), cqf (path), reflection (path)
#880 Additional test cases for date/time arithmetic 5.5 "date time", time, date, cql (path)
#931 Library XML deserializer doesn't include annotations 5 classes, java (path), src (path), opencds (path), engine (path), main (path), org (path), cql (path), cqf (path)

Tip: If this PR addresses any of these issues, please link them using Closes #NNN or Refs #NNN in the PR description.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.97%. Comparing base (094e34e) to head (70d8fc3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1698   +/-   ##
=========================================
  Coverage     61.97%   61.97%           
  Complexity     3940     3940           
=========================================
  Files           210      210           
  Lines         20366    20366           
  Branches       3879     3879           
=========================================
  Hits          12621    12621           
  Misses         6138     6138           
  Partials       1607     1607

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 344e827 into main Mar 12, 2026
10 of 11 checks passed
@JPercival JPercival deleted the time-reflection-engine-js branch March 12, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPercival JPercival JPercival approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antvaset @JPercival