Conversation
…rDecorator null cache bug Add EnableDetailedTracing engine option that captures every sub-expression's result in the trace tree. When enabled, visitExpression() wraps each non-filtered expression evaluation with sub-expression frame push/pop, producing a full trace of intermediate computations. A configurable filter skips trivial leaf nodes (Literal, Null, OperandRef, etc.) by default.
|
Formatting check succeeded! |
JPercival
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
=========================================
Coverage 61.97% 61.97%
Complexity 3940 3940
=========================================
Files 210 210
Lines 20366 20366
Branches 3879 3879
=========================================
Hits 12621 12621
Misses 6138 6138
Partials 1607 1607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contributor
Author
|
I have added tests - so surely not 0% coverage on new code. I believe the issue is that the cql.kotlin-multiplatform-conventions plugin (used by the engine module) does not include JaCoCo. Only cql.kotlin-conventions does. So the engine's jvmTest runs without the JaCoCo agent, producing no coverage data for SonarQube. Addressing that is outside the scope of this PR |
antvaset
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add EnableDetailedTracing engine option that captures every sub-expression's result in the trace tree. When enabled, visitExpression() wraps each non-filtered expression evaluation with sub-expression frame push/pop, producing a full trace of intermediate computations. A configurable filter skips trivial leaf nodes (Literal, Null, OperandRef, etc.) by default.
I have actually built this locally to test out in a measure evaluation stack. Here is an example of what the detailed tracing logs look like:
{ "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "expressionName": "Antidiabetic Drugs Administered or Ordered", "locator": "60:1-67:3", "context": "nhsn-iip-ip101", "result": "[MedicationRequest/nhsn-iip-add101, MedicationRequest/nhsn-iip-add101-10]", "children": [ { "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "nodeType": "Union", "locator": "61:3-67:3", "context": "nhsn-iip-ip101", "result": "[MedicationRequest/nhsn-iip-add101, MedicationRequest/nhsn-iip-add101-10]", "children": [ { "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "nodeType": "As", "context": "nhsn-iip-ip101", "result": "[]", "children": [ { "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "nodeType": "Query", "locator": "61:3-63:43", "context": "nhsn-iip-ip101", "result": "[]", "children": [ { "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "nodeType": "Retrieve", "locator": "61:4-61:29", "context": "nhsn-iip-ip101", "result": "[]", "children": [ { "library": "NHSNGlycemicControlHypoglycemicInitialPopulation", "libraryVersion": "0.0.002", "nodeType": "Retrieve", "locator": "61:4-61:29", "context": "nhsn-iip-ip101", "result": "null" } ] } ] } ] } ... Snipped