Skip to content

#1681: Skip version check when requesting a library without a version or if the resolved library does not have a version#1693

Merged
JPercival merged 2 commits intomainfrom
skip-library-version-checks-for-null-versions
Mar 1, 2026
Merged

#1681: Skip version check when requesting a library without a version or if the resolved library does not have a version#1693
JPercival merged 2 commits intomainfrom
skip-library-version-checks-for-null-versions

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Feb 27, 2026

Closes #1681.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 27, 2026

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.97%. Comparing base (ccc02dd) to head (2fd1bfb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1693   +/-   ##
=========================================
  Coverage     61.97%   61.97%           
  Complexity     3940     3940           
=========================================
  Files           210      210           
  Lines         20366    20366           
  Branches       3879     3879           
=========================================
  Hits          12621    12621           
  Misses         6138     6138           
  Partials       1607     1607

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antvaset antvaset changed the title #1681: Skip version check if the requested version is null or if the resolved library does not have a version #1681: Skip version check when requesting a library without a version or if the resolved library does not have a version Feb 27, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 27, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit b25f6bd into main Mar 1, 2026
8 of 9 checks passed
@JPercival JPercival deleted the skip-library-version-checks-for-null-versions branch March 1, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brynrhodes brynrhodes brynrhodes approved these changes

@JPercival JPercival JPercival approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow version to be assumed in included libraries

3 participants

@antvaset @brynrhodes @JPercival