Skip to content

Implement runtime type checking against ELM result types and report type drift.#1673

Merged
JPercival merged 5 commits intomasterfrom
feature/runtime-type-checking
Feb 19, 2026
Merged

Implement runtime type checking against ELM result types and report type drift.#1673
JPercival merged 5 commits intomasterfrom
feature/runtime-type-checking

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Feb 4, 2026

  • Add the EnableTypeChecking engine option (disabled by default). When type checking is enabled, the dynamic runtime value types are checked against the static result types from the ELM. Mismatches are logged as warnings and can help debug and diagnose the drift.
  • So far, I found potential issues in the Power, DifferenceBetween, DurationBetween, CalculateAge, CalculateAgeAt operators, which may have been already reported.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 69.44444% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.66%. Comparing base (dcdf16c) to head (1ed4c37).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rg/opencds/cqf/cql/engine/execution/TypeChecker.kt 68.62% 21 Missing and 11 partials ⚠️
...ncds/cqf/cql/engine/execution/EvaluationVisitor.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1673      +/-   ##
============================================
+ Coverage     65.65%   65.66%   +0.01%     
  Complexity     1645     1645              
============================================
  Files           480      481       +1     
  Lines         27776    27890     +114     
  Branches       5523     5553      +30     
============================================
+ Hits          18235    18315      +80     
- Misses         7216     7231      +15     
- Partials       2325     2344      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antvaset antvaset marked this pull request as ready for review February 4, 2026 10:07
@antvaset antvaset enabled auto-merge (squash) February 18, 2026 03:02
@JPercival JPercival disabled auto-merge February 19, 2026 22:07
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
79.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit af81f77 into master Feb 19, 2026
8 of 9 checks passed
@JPercival JPercival deleted the feature/runtime-type-checking branch February 19, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants