Shift Equal and Equivalent evaluation logic into respective evaluators#1668
Merged
Shift Equal and Equivalent evaluation logic into respective evaluators#1668
Equal and Equivalent evaluation logic into respective evaluators#1668Conversation
|
Formatting check succeeded! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1668 +/- ##
============================================
+ Coverage 65.88% 65.89% +0.01%
Complexity 1645 1645
============================================
Files 477 478 +1
Lines 27505 27641 +136
Branches 5471 5497 +26
============================================
+ Hits 18121 18215 +94
- Misses 7084 7098 +14
- Partials 2300 2328 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # Src/java/engine/src/main/kotlin/org/opencds/cqf/cql/engine/elm/executing/EqualEvaluator.kt # Src/java/engine/src/main/kotlin/org/opencds/cqf/cql/engine/elm/executing/EquivalentEvaluator.kt # Src/java/engine/src/main/kotlin/org/opencds/cqf/cql/engine/runtime/Ratio.kt
|
JPercival
approved these changes
Jan 28, 2026
lukedegruchy
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EqualandEquivalentoperators intoEqualEvaluatorandEquivalentEvaluator.statefields fromTupleandInterval.Equivalentfor CQL Long type. For CQL Long, equivalence is the same as equality https://cql.hl7.org/09-b-cqlreference.html#equivalent.This should also help clearly differentiate between CQL's
EqualorEquivalentand Java's.equals().