Skip to content

Add library params builder to improve the engine evaluate API for Java users#1658

Merged
JPercival merged 3 commits intomasterfrom
add-library-params-builder
Jan 13, 2026
Merged

Add library params builder to improve the engine evaluate API for Java users#1658
JPercival merged 3 commits intomasterfrom
add-library-params-builder

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Jan 5, 2026 •
edited
Loading

Adds LibraryParams class with a builder that can be used in Java as follows

var lib1ParamsBuilder = new EvaluationParams.LibraryParams.Builder();
lib1ParamsBuilder.expressions("expr1");
// ...
evaluationParamsBuilder.library("lib1", lib1ParamsBuilder.build());

Kotlin usage is documented here for context https://github.com/cqframework/clinical_quality_language/wiki/CQL-Engine-Evaluation-API.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.88%. Comparing base (fc46135) to head (5ec3a12).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...encds/cqf/cql/engine/execution/EvaluationParams.kt 81.81% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1658      +/-   ##
============================================
- Coverage     65.88%   65.88%   -0.01%     
  Complexity     1645     1645              
============================================
  Files           477      477              
  Lines         27496    27503       +7     
  Branches       5467     5470       +3     
============================================
+ Hits          18117    18120       +3     
- Misses         7083     7084       +1     
- Partials       2296     2299       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antvaset antvaset marked this pull request as draft January 5, 2026 20:22
@antvaset antvaset marked this pull request as ready for review January 5, 2026 20:54
@JPercival JPercival enabled auto-merge (squash) January 12, 2026 23:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 0399fa1 into master Jan 13, 2026
9 checks passed
@JPercival JPercival deleted the add-library-params-builder branch January 13, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukedegruchy lukedegruchy lukedegruchy approved these changes

@JPercival JPercival JPercival approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antvaset @lukedegruchy @JPercival