Skip to content

Fix warnings, add readmes, create detekt baseline#1625

Merged
JPercival merged 3 commits intomasterfrom
engine-warning-cleanup
Oct 8, 2025
Merged

Fix warnings, add readmes, create detekt baseline#1625
JPercival merged 3 commits intomasterfrom
engine-warning-cleanup

Conversation

@JPercival
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.70%. Comparing base (72e29d9) to head (9cc78a9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../cqf/cql/engine/elm/executing/ChildrenEvaluator.kt 0.00% 12 Missing ⚠️
.../cqf/cql/engine/elm/executing/RetrieveEvaluator.kt 27.27% 3 Missing and 5 partials ⚠️
...otlin/org/opencds/cqf/cql/engine/debug/Location.kt 0.00% 3 Missing and 2 partials ⚠️
...cds/cqf/cql/engine/fhir/model/FhirModelResolver.kt 69.23% 4 Missing ⚠️
...cql/engine/fhir/converter/BaseFhirTypeConverter.kt 77.77% 1 Missing and 1 partial ⚠️
...cds/cqf/cql/engine/elm/executing/QueryEvaluator.kt 87.50% 0 Missing and 2 partials ⚠️
.../opencds/cqf/cql/engine/data/SystemDataProvider.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1625      +/-   ##
============================================
+ Coverage     65.69%   65.70%   +0.01%     
- Complexity     1644     1646       +2     
============================================
  Files           470      470              
  Lines         28000    27989      -11     
  Branches       5427     5429       +2     
============================================
- Hits          18394    18391       -3     
+ Misses         7319     7309      -10     
- Partials       2287     2289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
35.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JPercival JPercival merged commit d792a4a into master Oct 8, 2025
9 of 11 checks passed
@JPercival JPercival deleted the engine-warning-cleanup branch October 8, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants