Skip to content

Engine warning cleanup#1624

Merged
JPercival merged 10 commits intomasterfrom
engine-warning-cleanup
Oct 7, 2025
Merged

Engine warning cleanup#1624
JPercival merged 10 commits intomasterfrom
engine-warning-cleanup

Conversation

@JPercival
Copy link
Copy Markdown
Contributor

@JPercival JPercival commented Oct 6, 2025

  • Add OpenRewrite framework as an auxiliary module
    • Create Recipe for mass-refactoring of String.format usages
  • Fix numerous detekt warnings on newly converted modules
    • Still several hundred warnings remain before we can fully enable the static analysis
  • Remove old Java-based static analysis tools.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 31.65618% with 326 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.69%. Comparing base (8369779) to head (8af87cf).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...kotlin/org/cqframework/fhir/utilities/IGContext.kt 20.68% 23 Missing ⚠️
...framework/cql/tools/xsd2modelinfo/ModelImporter.kt 25.00% 13 Missing and 5 partials ⚠️
...n/kotlin/org/cqframework/fhir/npm/LibraryLoader.kt 11.11% 11 Missing and 5 partials ⚠️
.../opencds/cqf/cql/engine/data/SystemDataProvider.kt 18.75% 13 Missing ⚠️
...elm/requirements/fhir/DataRequirementsProcessor.kt 44.44% 6 Missing and 4 partials ⚠️
...cds/cqf/cql/engine/fhir/model/FhirModelResolver.kt 23.07% 10 Missing ⚠️
.../org/opencds/cqf/cql/engine/debug/SourceLocator.kt 38.46% 2 Missing and 6 partials ⚠️
...rg/opencds/cqf/cql/engine/execution/Environment.kt 65.21% 4 Missing and 4 partials ⚠️
...ds/cqf/cql/engine/elm/executing/ExpandEvaluator.kt 65.00% 5 Missing and 2 partials ⚠️
...otlin/org/opencds/cqf/cql/engine/debug/DebugMap.kt 0.00% 6 Missing ⚠️
... and 156 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1624      +/-   ##
============================================
+ Coverage     65.05%   65.69%   +0.63%     
+ Complexity     1646     1644       -2     
============================================
  Files           470      470              
  Lines         28431    28000     -431     
  Branches       5440     5427      -13     
============================================
- Hits          18497    18394     -103     
+ Misses         7643     7319     -324     
+ Partials       2291     2287       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
40.4% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JPercival JPercival merged commit 72e29d9 into master Oct 7, 2025
8 of 9 checks passed
@JPercival JPercival deleted the engine-warning-cleanup branch October 7, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brynrhodes brynrhodes brynrhodes approved these changes

@antvaset antvaset antvaset approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JPercival @brynrhodes @antvaset