Skip to content

Convert engine main to Kotlin#1619

Merged
JPercival merged 4 commits intomasterfrom
engine-kotlin-conversion
Oct 6, 2025
Merged

Convert engine main to Kotlin#1619
JPercival merged 4 commits intomasterfrom
engine-kotlin-conversion

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Oct 3, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 65.34653% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.05%. Comparing base (2a301b1) to head (ed0126f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cds/cqf/cql/engine/fhir/model/FhirModelResolver.kt 60.86% 8 Missing and 1 partial ⚠️
...e/fhir/terminology/Dstu3FhirTerminologyProvider.kt 14.28% 5 Missing and 1 partial ⚠️
...qf/cql/engine/fhir/model/Dstu2FhirModelResolver.kt 28.57% 5 Missing ⚠️
...qf/cql/engine/fhir/model/Dstu3FhirModelResolver.kt 20.00% 2 Missing and 2 partials ⚠️
...s/cqf/cql/engine/fhir/model/R5FhirModelResolver.kt 20.00% 4 Missing ⚠️
...s/cqf/cql/engine/fhir/model/R4FhirModelResolver.kt 40.00% 1 Missing and 2 partials ⚠️
...cql/engine/fhir/converter/BaseFhirTypeConverter.kt 0.00% 0 Missing and 1 partial ⚠️
...f/cql/engine/fhir/converter/R4FhirTypeConverter.kt 90.00% 0 Missing and 1 partial ⚠️
...cql/engine/fhir/retrieve/BaseFhirQueryGenerator.kt 75.00% 0 Missing and 1 partial ⚠️
...gine/fhir/terminology/R4FhirTerminologyProvider.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1619      +/-   ##
============================================
+ Coverage     63.86%   65.05%   +1.19%     
- Complexity      935     1646     +711     
============================================
  Files           309      470     +161     
  Lines         11516    28431   +16915     
  Branches       2418     5440    +3022     
============================================
+ Hits           7355    18497   +11142     
- Misses         3034     7643    +4609     
- Partials       1127     2291    +1164

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
66.1% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@antvaset antvaset marked this pull request as ready for review October 6, 2025 19:45
@antvaset antvaset changed the title Convert engine main to Kotlin (WIP) Convert engine main to Kotlin Oct 6, 2025
@JPercival JPercival merged commit b32660a into master Oct 6, 2025
8 of 9 checks passed
@JPercival JPercival deleted the engine-kotlin-conversion branch October 6, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPercival JPercival JPercival approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antvaset @JPercival