Formatting check succeeded!

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.88%. Comparing base (43fed87) to head (b244e0c).
⚠️ Report is 2 commits behind head on master.

@@            Coverage Diff            @@
##             master    #1605   +/-   ##
=========================================
  Coverage     62.88%   62.88%           
  Complexity     1863     1863           
=========================================
  Files           341      341           
  Lines         14925    14925           
  Branches       2966     2966           
=========================================
  Hits           9385     9385           
  Misses         4060     4060           
  Partials       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival - One of our CQL Translations Service tests just started failing with this change. It is a test for properly returning an error when an included library is missing.

Whereas a missing library used to result in this annotation:

{
  "type": "CqlToElmError",
  "libraryId": "CMS146",
  "libraryVersion": "2",
  "startLine": 5,
  "startChar": 1,
  "endLine": 5,
  "endChar": 37,
  "message": "Could not load source for library CMSAll, version 1, namespace uri null.",
  "errorType": "include",
  "errorSeverity": "error",
  "targetIncludeLibraryId": "CMSAll",
  "targetIncludeLibraryVersionId": "1"
}

It now results in this annotation:

{
  "type": "CqlToElmError",
  "libraryId": "CMS146",
  "libraryVersion": "2",
  "startLine": 5,
  "startChar": 1,
  "endLine": 5,
  "endChar": 37,
  "message": "Could not load source for library CMSAll, version 1, namespace uri null.",
  "errorType": "internal",
  "errorSeverity": "error"
}

Note that:

• errorType changes from include to internal
• targetIncludeLibraryId is no longer provided
• targetIncludeLibraryVersionId is no longer provided

I see that CqlIncludeException still exists as a specific exception in the Java code, but it seems all its specificity is now removed in the serialization to an annotation. Is that intentional (for example, as part of an effort to normalize annotations to just a few types and common schemas)?