Conversation
Contributor
lukedegruchy
commented
Aug 13, 2025
- Non-functional change strictly to improve code quality and readability for State#popEvaluatedResourceStack, since the intent of the current code is difficult to ascertain but is technically correct
|
Formatting check succeeded! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
============================================
- Coverage 65.22% 65.21% -0.01%
+ Complexity 1977 1976 -1
============================================
Files 503 503
Lines 29065 29069 +4
Branches 5689 5690 +1
============================================
+ Hits 18957 18958 +1
- Misses 7784 7786 +2
- Partials 2324 2325 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Chris0296
approved these changes
Aug 13, 2025
Contributor
Chris0296
left a comment
There was a problem hiding this comment.
LGTM! Certainly more readable.
antvaset
approved these changes
Aug 14, 2025
JPercival
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.