Conversation
|
Formatting check succeeded! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1593 +/- ##
============================================
- Coverage 65.08% 65.07% -0.01%
+ Complexity 1977 1976 -1
============================================
Files 499 499
Lines 28832 28828 -4
Branches 5672 5671 -1
============================================
- Hits 18765 18761 -4
- Misses 7742 7743 +1
+ Partials 2325 2324 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
brynrhodes
approved these changes
Jul 31, 2025
JPercival
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keys in the entries added to the
functionHeadersByDefandfunctionDefinitionsHashMaps are mutated as the visitor goes on. This breaks subsequent lookups based onhashCodes.IdentityHashMaps can be used instead to map and look up by reference.