Conversation
* Try out jsRun * Compile Kotlin to JS with type definitions. Export parseToTree method.
* WIP * WIP * WIP * Working? * Fix usage of Java 17 API * Update checkstyle rules * Fix static analysis * Updates to src dirs * Fixing up missing test sourceSet * Try another way to specify the antlr directory * Third different way * Add some logging * merge master * Change toolchain resolution * Fix tests * More tweaks to animalsniffer * Fix formatting * Trying random stuff * More random stuff * Small improvements for Gradle build (#1418) * Removing references to idea * Fix duplicative generation * Remove references to idea project generation --------- Co-authored-by: Anton Vasetenkov <antvaset@gmail.com>
* small cleanup * fix the jvm toolchain version --------- Co-authored-by: Anton Vasetenkov <antvaset@gmail.com>
…formance) to CQL to ELM UI.
Multiplatform filesystem using kotlinx.io.files
# Conflicts: # Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/execution/CqlEngine.java # Src/java/gradle.properties
|
brynrhodes
approved these changes
Sep 24, 2025
cmoesel
approved these changes
Sep 24, 2025
Member
cmoesel
left a comment
There was a problem hiding this comment.
I'm not able to review the hundreds of files again, but based on the quality of code from past reviews, successful integration into the CQL Translation Service, and some initial success regression testing a set of our CQL libraries with this, and assuming this has undergone internal code review, I'm comfortable approving.
Amazing work, @JPercival and @antvaset. This is so very cool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's included:
cql-to-elmproject (CQL compiler) and its dependencies are converted to Kotlin Multiplatform.See also https://github.com/cqframework/clinical_quality_language/wiki/v3-to-v4-Migration.