Skip to content

Add pre-commit#321

Merged
aaronliu0130 merged 1 commit intodevelopfrom
pre-commit
Mar 6, 2025
Merged

Add pre-commit#321
aaronliu0130 merged 1 commit intodevelopfrom
pre-commit

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Mar 4, 2025 •
edited
Loading

https://pre-commit.com

% pipx install pre-commit # or uv tool install pre-commit
% pre-commit install

pre-commit installed at .git/hooks/pre-commit

% pre-commit autoupdate

[https://github.com/codespell-project/codespell] already up to date!
[https://github.com/tox-dev/pyproject-fmt] already up to date!
[https://github.com/abravalheri/validate-pyproject] already up to date!

% pre-commit run --all-files

codespell................................................................Passed
pyproject-fmt............................................................Passed
Validate pyproject.toml..................................................Passed

% git commit -am"Add pre-commit"

codespell................................................................Passed
pyproject-fmt............................................................Passed
Validate pyproject.toml..................................................Passed
[pre-commit 6dcbda1] Add pre-commit
 3 files changed, 40 insertions(+), 9 deletions(-)
 create mode 100644 .pre-commit-config.yaml

aaronliu0130
aaronliu0130 previously requested changes Mar 5, 2025
View reviewed changes
@cclauss cclauss requested review from aaronliu0130 and jayvdb March 6, 2025 05:44
@cclauss cclauss mentioned this pull request Mar 6, 2025
Closed
@aaronliu0130
Copy link
Member

aaronliu0130 commented Mar 6, 2025 via email

@cclauss cclauss dismissed aaronliu0130’s stale review March 6, 2025 15:10

flake8 dropped

@cclauss
Copy link
Member Author

cclauss commented Mar 6, 2025

Let's drop flake8 so we can get pre-commit in place.

@cclauss
Copy link
Member Author

cclauss commented Mar 6, 2025 •
edited
Loading

Please read the first few paragraphs of the README of https://github.com/psf/black

@aaronliu0130 aaronliu0130 merged commit cba132c into develop Mar 6, 2025
@cclauss cclauss deleted the pre-commit branch March 6, 2025 22:35
@aaronliu0130
Copy link
Member

aaronliu0130 commented Mar 6, 2025

Actions in this workflow must be: within a repository owned by cpplint, created by GitHub, or verified in the GitHub Marketplace.

Apparently it's not verified in the marketplace. I should've noticed that no tests were run. The workflow's page also says it's in maintenance-only mode and suggests "generally you want to use pre-commit.ci which is faster and has more features." which is an entirely separate GitHub app. @cclauss, I'm assuming you can't disable whatever repo setting that's causing the workflow verification requirement either? Should we just remove the pre-commit CI and just have tox run pre-commit instead?

Also, I've thought about it a bit, and I no longer object to the removal of extra string indentation.

@cclauss
Copy link
Member Author

cclauss commented Mar 6, 2025

@aaronliu0130 aaronliu0130 mentioned this pull request Apr 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayvdb jayvdb jayvdb approved these changes

@aaronliu0130 aaronliu0130 aaronliu0130 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @aaronliu0130 @jayvdb