fix: treat clang-format --lines as inclusive ranges
#175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref cpp-linter/cpp-linter-action#388 See also official [LLVM python script][llvm-py] about their use of `--lines` values. I updated some of the test assets to correspond with these changes.. [llvm-py]: https://github.com/llvm/llvm-project/blob/14784225cf028af54dda350114d5495ab94d572e/clang/tools/clang-format/git-clang-format#L633
WalkthroughAdjusted inclusive handling of line ranges and test expectations: clarified clang-format line-range comment; changed range consolidation to stop extending end by +1; updated multiple test JSON files and a unit test to reflect the new inclusive range boundaries. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 23 23
Lines 1897 1897
=======================================
Hits 1864 1864
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Apparently, this is already being done in cpp-linter-rs. |
Contributor
Author
|
I looked at the history of the LLVM py script... The |
shenxianpeng
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref cpp-linter/cpp-linter-action#388
See also official LLVM python script about their use of
--linesvalues.I updated some of the test assets to correspond with these changes..
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.