P2372R3 Fixing locale handling in chrono formatters#5005
Merged
Conversation
d975fee to
8aa8cd7
Compare
JohelEGP
suggested changes
Oct 6, 2021
b641037 to
14a3b85
Compare
timsong-cpp
reviewed
Oct 16, 2021
1b6a649 to
42bcbf0
Compare
burblebee
requested changes
Oct 16, 2021
Contributor
burblebee
left a comment
There was a problem hiding this comment.
Other than 2 issues I had with the paper, just the "C" needs to be \tcoded (as already mentioned by timsong-cpp).
burblebee
approved these changes
Oct 16, 2021
Contributor
burblebee
left a comment
There was a problem hiding this comment.
"C" has been fixed, but issues with wording remain.
In [time.zone.zonedtime.nonmembers], remove the separate "Returns" item now that have "Effects: Equivalent to: return ..."
42bcbf0 to
582ec50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4973
Fixes cplusplus/papers#1039