Skip to content

feat: add Modern Greek translations#984

Merged
RysteQ merged 7 commits into
cpeditor:masterfrom
RysteQ:master
Oct 10, 2021
Merged

feat: add Modern Greek translations#984
RysteQ merged 7 commits into
cpeditor:masterfrom
RysteQ:master

Conversation

@RysteQ

@RysteQ RysteQ commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Added the Modern Greek translation file for the application

This closes #972.

Added the Modern Greek translation for the application
@ouuan ouuan mentioned this pull request Sep 2, 2021
5 tasks
@ouuan ouuan changed the title Modern Greek translation file feat: add Modern Greek translations Sep 2, 2021
@ouuan

ouuan commented Sep 2, 2021

Copy link
Copy Markdown
Member

It would be better if you can ask other native speakers to review these translations. It's not necessary, though.

@ouuan

ouuan commented Sep 2, 2021

Copy link
Copy Markdown
Member

@allcontributors add @RysteQ as a contributor for translations.

@allcontributors

Copy link
Copy Markdown
Contributor

@ouuan

I've put up a pull request to add @RysteQ! 🎉

ouuan
ouuan previously approved these changes Sep 2, 2021
@ouuan

ouuan commented Sep 2, 2021

Copy link
Copy Markdown
Member

@RysteQ I've invited you to @cpeditor organization. After accepting the invitation, you'll have write access to this repository. This means that you can directly push to this repository (except the master branch and version branches), including pull requests opened by others, instead of pushing to your fork in the future.

If you think no further review is needed, you can squash and merge (click the down arrow and choose "Squash and merge").

@RysteQ

RysteQ commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

Thank you !
I will try to find competitive programmers that know the language and are willing to give cpeditor a try to review my translation.

@RysteQ RysteQ closed this Sep 2, 2021
@ouuan

ouuan commented Sep 2, 2021

Copy link
Copy Markdown
Member

Why close?

@ouuan ouuan reopened this Sep 9, 2021
@RysteQ

RysteQ commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

This closes #972

@ouuan

ouuan commented Sep 26, 2021

Copy link
Copy Markdown
Member

@RysteQ I just realized that you are not an organization member. Please check your email inbox and accept the invitation. I thought you had already accepted it and were able to merge this PR. Remember to "Squash and merge" instead of "Create a merge commit".

@ouuan

ouuan commented Sep 26, 2021

Copy link
Copy Markdown
Member

Or if you think everything is OK, you can tell me and I'll merge this.

@coder3101

Copy link
Copy Markdown
Member

@RysteQ are you still willing to complete this PR?

@RysteQ

RysteQ commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

Oh sorry, I was quite inactive these last few days due to university preparation, I will finish the ReadMe.md file as I promised in my first issue. If I forget to do something please inform me !

Also, let me check for any grammar error I may very well have forgotten due to my quite hastily done translation file.

@RysteQ

RysteQ commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

Okay, I have translated the README.md file and fixed some minor (but embarrassing) grammar mistakes in the translation files. If I forget anything else, which is likely to happen due to this being my first ever contribution to open source, please inform me of what I can do!

@coder3101 coder3101 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RysteQ RysteQ merged commit c956ce0 into cpeditor:master Oct 10, 2021
@ouuan

ouuan commented Oct 10, 2021

Copy link
Copy Markdown
Member

Remember to choose "squash and merge" next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modern Greek translation

3 participants