Skip to content

fix: change swap-line shortcuts on macos#876

Merged
swiftqwq merged 6 commits into
v6.9from
fix-863
Jun 20, 2021
Merged

fix: change swap-line shortcuts on macos#876
swiftqwq merged 6 commits into
v6.9from
fix-863

Conversation

@ouuan

@ouuan ouuan commented Jun 16, 2021 •
edited by swiftqwq
Loading

Copy link
Copy Markdown
Member

Description

Change swap-line shortcuts as requested in #863.

Related Issues / Pull Requests

This fixes #863.

How Has This Been Tested?

@swift-zym Can you test this?

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

@ouuan ouuan requested review from coder3101 and swiftqwq June 16, 2021 14:42
@swiftqwq

swiftqwq commented Jun 17, 2021

Copy link
Copy Markdown
Member

@ouuan It seems didn't work well on my Mac.

swiftqwq
swiftqwq reviewed Jun 17, 2021
View reviewed changes
Comment thread src/appwindow.cpp Outdated
@ouuan ouuan changed the base branch from master to v6.9 June 18, 2021 03:32
@ouuan ouuan requested a review from swiftqwq June 18, 2021 03:33
swiftqwq
swiftqwq reviewed Jun 18, 2021
View reviewed changes

@swiftqwq swiftqwq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why... but it still didn't work.

swiftqwq
swiftqwq previously approved these changes Jun 18, 2021
View reviewed changes

@swiftqwq swiftqwq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now.

@swiftqwq swiftqwq enabled auto-merge (squash) June 18, 2021 14:15
@ouuan ouuan requested review from coder3101 and neko-para and removed request for coder3101 June 18, 2021 16:50
coder3101
coder3101 previously approved these changes Jun 20, 2021
View reviewed changes

@coder3101 coder3101 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command+Control+Up/Down works fine on MBP macOS Big Sur 11.4

@coder3101 coder3101 dismissed stale reviews from swiftqwq and themself via d82e91a June 20, 2021 04:06
@coder3101 coder3101 requested a review from swiftqwq June 20, 2021 04:06
@ouuan ouuan requested a review from coder3101 June 20, 2021 04:16
@swiftqwq swiftqwq merged commit 005cb49 into v6.9 Jun 20, 2021
@swiftqwq swiftqwq deleted the fix-863 branch June 20, 2021 04:48
@coder3101

coder3101 commented Jun 20, 2021

Copy link
Copy Markdown
Member

@ouuan v6.9 is 4 commits ahead master, please create a PR for master from that version branch.

@ouuan

ouuan commented Jun 20, 2021

Copy link
Copy Markdown
Member Author

@ouuan v6.9 is 4 commits ahead master, please create a PR for master from that version branch.

6.9.2 will come soon.

@ouuan

ouuan commented Jun 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

6.9.2 will come soon.

Shall we wait for #835?

@coder3101

coder3101 commented Jun 20, 2021

Copy link
Copy Markdown
Member

6.9.2 will come soon.

Shall we wait for #835?

Sure

@swiftqwq

swiftqwq commented Jun 20, 2021

Copy link
Copy Markdown
Member

Why #863 still open?

@coder3101

coder3101 commented Jun 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Why #863 still open?

Because neither merged to master nor released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

@swiftqwq swiftqwq swiftqwq approved these changes

@neko-para neko-para Awaiting requested review from neko-para

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swap-line shortcuts don't work on macOS

3 participants

@ouuan @swiftqwq @coder3101