Skip to content

Fix selection when Dark Fusion is selected#794

Merged
coder3101 merged 2 commits into
cpeditor:masterfrom
sonulohani:fix_dark_fusion
Mar 12, 2021
Merged

Fix selection when Dark Fusion is selected#794
coder3101 merged 2 commits into
cpeditor:masterfrom
sonulohani:fix_dark_fusion

Conversation

@sonulohani

@sonulohani sonulohani commented Mar 11, 2021 •
edited by coder3101
Loading

Copy link
Copy Markdown
Contributor

Fixes

Closes #788

Screenshots (if appropriate)

Light theme

image

Monokai theme

image

Dracula theme

image

Solarized Light

image

Solarized Dark

image

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

coder3101
coder3101 previously approved these changes Mar 11, 2021
View reviewed changes
@coder3101

coder3101 commented Mar 11, 2021

Copy link
Copy Markdown
Member

Document these changes in Changelog's fixes section.

@coder3101

coder3101 commented Mar 11, 2021

Copy link
Copy Markdown
Member

@all-contributors please add @sonulohani for code

@allcontributors

allcontributors Bot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

@coder3101

@sonulohani already contributed before to code

@sonulohani

sonulohani commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

Document these changes in Changelog's fixes section.

Done

coder3101
coder3101 approved these changes Mar 12, 2021
View reviewed changes

@coder3101 coder3101 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonulohani

sonulohani commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

LGTM!

Please merge it then. Thanks

@coder3101 coder3101 merged commit 968a450 into cpeditor:master Mar 12, 2021
@sonulohani sonulohani deleted the fix_dark_fusion branch March 13, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Selected characters in Dark Fusion has dark background

2 participants

@sonulohani @coder3101