fix: make signal handler more robust & fix clang-tidy issues#1166
Merged
Conversation
swiftqwq
previously approved these changes
Apr 9, 2023
Member
Author
|
I'm not sure whether using C++17 is a real fix for |
Member
Author
|
Maybe we should follow Calling Qt Functions From Unix Signal Handlers | Qt 5.15 |
Member
Author
|
Tested on Arch Linux only. |
coder3101
approved these changes
Apr 12, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppcoreguidelines-avoid-do-whilebugprone-signal-handler