Docker: Migrate Intel tests to CMake#4550
Conversation
|
For the record, this was your call when the Regtest were sorted out. Now you're doing it yourself; much appreciated! |
d921a6f to
b618dcf
Compare
|
Sorry for the confusion. This is just to test the water. |
d3748ea to
37ec76f
Compare
|
It doesn't look too good: While the ifort gets stuck on grid_dgemm_prepare_pab.c the ifx struggles to parse DBCSR. |
I think, I prepared DBCSR for Intel Compiler and had various updates at the CMake compiler spec level, etc. This is not part of any recent DBCSR v2.8.0. Can you try something like dbcsr@develop? Regarding the |
51036b6 to
8fbf33d
Compare
Switching to DBCSR's development branch definitely helped. @alazzaro, would it be possible to make a DBCSR release before the upcoming CP2K release? |
That's the plan. I will release a RC candidate next week. |
Awesome. Thanks! To be honest, I'm struggling a bit with this PR. @hfp, maybe you could take a look? These Intel tests are actually the last place where the CI uses the Makefile. It'd be great if we could delete the Makefile by the end of next week, so that we still have some time before the release. |
|
Updating here for completeness https://github.com/cp2k/dbcsr/releases/tag/v2.9.0 |
|
Updating from oneapi-hpckit:2025.2.2-0 to oneapi-hpckit:2025.3.0-0 is not a good idea since IFX 2025.3 regressed (I am on it). See also #4553 (comment). |
36f3f0c to
7a7e53d
Compare
7a7e53d to
2b9ce56
Compare
|
I rebased onto DBCSR 2.9.0 and went back to
|
We have some workarounds appended when generating the ARCH-file (overriding Makefile rules), but no equivalent yet for the CMake based approach. I can take over and work on it. Results are more likely post-holiday... |
That would be great!
Yeah, I know. The usual end of year rush :-) I guess it would have been smarter to conclude the CMake migration with our mid-year release. However, now that we're almost there, I really want to put the lid on. To ensure nothing was forgotten, it would be good if I could delete the Makefile before the holidays. So.... do you think it would be ok to merge this PR as is and break the intel tests for a few days? |
|
That's fine too. Once we have migrated, I can also enable some currently unsupported combinations. For instance, GNU Fortran and Intel MPI/MKL are a good "team". It's my own preferred recipe. I worked upstream on Spack to make the mentioned combo working already. |
|
As a side note, I am potentially holding back some PRs for post-release (targeting DBM, Offload, and some CP2K components). |
No description provided.