Sternheimer BSE (1. Version with W matrix given)#4445
Conversation
a5f7f8a to
dc7bf88
Compare
1a46888 to
a878c74
Compare
| @@ -0,0 +1,7 @@ | |||
| # runs are executed in the same order as in this file | |||
There was a problem hiding this comment.
Please add this new test directory to the TEST_DIRS file.
There was a problem hiding this comment.
Yes, I forgot, thank you Ole!
d47505e to
005c906
Compare
|
It's hard to see at the moment (all red Dashboard), but I think this is related to the PR like Out-Of-Bounds accesses (OOBs):
|
|
@annahehn, could you please take a look at the failing |
|
The code somehow seems to mess up global/local indexes/bounds to some extent (this is only a very high-level first look). Perhaps it was not tested thoroughly with PSMP. |
|
Yes, there a few places where @annahehn is already working on this and I believe @fstein93 is helping. However, since it's now been |
|
Well, the branch/code is not lost if reverted. It's however an inconvenience to reapply with a new PR. In any case, it's a new PR and I am leaning towards a rollback if there are no conflicts or additional work for the person who reverts it. The current CI or Dashboard state seems degenerated like no clear visibility anymore if current/later contributions are valid or not. That's fine, I think, if we had no contributions or upcoming release. Depending on the timeline (far release or resolution), I would leave it or not. |
|
I am working on fixing the bugs. |
|
I do have an idea on how to fix it but it will take a bit of time to mimic the intended tensor contraction. I am currently in exchange with @annahehn on how to proceed. |
No description provided.