Skip to content

Add pxpotri with DLA-Future#4269

Merged
oschuett merged 10 commits intocp2k:masterfrom
RMeli:dla-pxpotri
Jul 21, 2025
Merged

Add pxpotri with DLA-Future#4269
oschuett merged 10 commits intocp2k:masterfrom
RMeli:dla-pxpotri

Conversation

@RMeli
Copy link
Member

@RMeli RMeli commented Jun 30, 2025

No description provided.

@mkrack
Copy link
Member

mkrack commented Jul 1, 2025

cscs-ci run eiger-spack-psmp

@RMeli It's weird that you could not trigger the cscs-ci run. I checked the list of globally trusted CI users and your username is included.

@mkrack
Copy link
Member

mkrack commented Jul 1, 2025

The CI test eiger-spack-psmp fails, because the branch dla-pxpotri does not include the most recent changes in the master.

@RMeli
Copy link
Member Author

RMeli commented Jul 1, 2025

It's weird that you could not trigger the cscs-ci run.

Indeed. I tried to change the capitalization of my username, but doesn't seem to be the problem. I'll have a look.

@mkrack
Copy link
Member

mkrack commented Jul 1, 2025

@RMeli There is a time out when pulling the CP2K image as sqsh file. That error did not appear before and is most likely not caused by this PR. Maybe, it is related to the migration eiger to eiger.alps?

@RMeli
Copy link
Member Author

RMeli commented Jul 1, 2025

It seems that there were JFrog issues around the time I triggered the build. I will try again, otherwise inquire internally (there were a few issues this morning due to the migration, but they should have been fixed).

@RMeli
Copy link
Member Author

RMeli commented Jul 1, 2025

cscs-ci run eiger-spack-psmp

@mkrack
Copy link
Member

mkrack commented Jul 1, 2025

It seems that the container download needs now 9 min and thus the time limit of 10 min for the test job is not sufficient.

@RMeli
Copy link
Member Author

RMeli commented Jul 1, 2025

Looks like the problem is with the entry point, and possibly with the switch from Sarus (on eiger) to the Container Engine (on eiger.alps).

I'm a bit time constrained this week, I'm writing you an e-mail to organize a meeting.

@RMeli RMeli marked this pull request as draft July 3, 2025 20:27
@mkrack
Copy link
Member

mkrack commented Jul 4, 2025

cscs-ci run daint-spack-psmp

@mkrack
Copy link
Member

mkrack commented Jul 4, 2025

cscs-ci run daint-toolchain-psmp

@mkrack
Copy link
Member

mkrack commented Jul 4, 2025

cscs-ci run eiger-spack-psmp

@RMeli RMeli marked this pull request as ready for review July 14, 2025 07:43
@RMeli
Copy link
Member Author

RMeli commented Jul 17, 2025

cscs-ci run eiger-spack-psmp

@RMeli
Copy link
Member Author

RMeli commented Jul 17, 2025

cscs-ci run daint-spack-psmp

@oschuett
Copy link
Member

Is this PR ready to be merged?

@RMeli
Copy link
Member Author

RMeli commented Jul 21, 2025

@oschuett I did fix the previous CI issues so for me it was ready to merge. But as discussed by e-mail, the changes introduced in #4297 make all DLA-Future tests fail due to an issue seemingly related to MPICH CH4:OFI.

@oschuett
Copy link
Member

While it's unfortunate that we can't run DLA-Future in the CI right now, I'm sure you tested this PR manually.
So, I'm leaning towards including it in the release nevertheless.

@mkrack
Copy link
Member

mkrack commented Jul 21, 2025

Should be fine for the release, since PR #4316 excludes DLAF for the time being.

@oschuett oschuett merged commit 74e72cd into cp2k:master Jul 21, 2025
41 checks passed
@RMeli RMeli deleted the dla-pxpotri branch July 21, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants